Code review comment for lp:~tribaal/landscape-charm/send-haproxy-error-in-relation

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Looks good, but marking as Needs fixing because there's some untested behavior and I'm a bit strong on using composition over inheritance when it makes sense (see the Mixin vs Fixture comment).

review: Needs Fixing

« Back to merge proposal