Code review comment for lp:~tribaal/charms/trusty/rabbitmq-server/add-pause-resume-actions

Revision history for this message
Chris Glass (tribaal) wrote :

> I think we need to avoid calling status_set directly in the actions, and move
> to updating the assess_status function in the main relations file to be pause
> aware; this will ensure that the next 'update-status' hook execution (which
> happens periodically in 1.25) will set the correct status of 'paused' rather
> than determining that rabbitmq is not running and setting 'blocked'

Excellent point. Changed the "status_set" to be in assess_status() as you suggested.

« Back to merge proposal