Code review comment for lp:~tribaal/charms/precise/storage/refactor-mount-volume

Revision history for this message
Chris Glass (tribaal) wrote :

Thanks for the review, and indeed, I think tweaking PYTHONPATH is exactly one of the ways to go (although it's not really nice to have to tweak things this way, it's quite un-pythoninc

However I would still like to address this in a later branch, since the diff is already quite large. The tests need rewriting, I think it's better to submit the changes in a separate branch to make sure the changes don't get drowned in the refactoring changes.

If you both insist, I can rewire things in this branch, but I suspect the diff will grow quite drastically.

« Back to merge proposal