OpenLP

Code review comment for lp:~trb143/openlp/splitter

  1. splitter
  2. Merge into trunk
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

I would prefer a different splitter, but that is just personal preference. Other than that, this looks fine to me.

Also, I'm not entirely sure that the <p> tag is a valid element in OpenLyrics, but let's roll with it and we can always sort out OpenLyrics later.

review: Approve

« Back to merge proposal