Code review comment for lp:~trb143/openlp/servicing

Revision history for this message
Michael Gorven (mgorven) wrote :

Eric4 files are gone! Awesome branch! :-P

+ log.debug(u'build_text_rectangle ')
+ log.debug(u'generate preview ')

May I be extremely pedantic and ask why there are trailing spaces?

+ if self.displayBlank == False:

I prefer code like "if not self.displayBlank" (unless displayBlank could
legitimately be None and needs to be treated differently).

 review approve

review: Approve

« Back to merge proposal