Just a note: I started naming things on forms before we had decided on a standard, so they're a little out of sync with the proper naming convention. I am cleaning them up in a cleanup branch, but just for reference, those two should probably be called "self.previewController"
982 + self.Toolbar.addToolbarButton("Move to top", ":/services/service_top.png",
983 + translate(u'ServiceManager', u'Move to start'), self.onServiceTop)
Not sure what the difference is between the first and second "move to top" strings is, but the first isn't u''
As noted before, my bad, these should be camelCase not PascalCase - also busy cleaning up in my branch.
Apart from those few minor things, everything looks fine. I'll still have to see these things in action to get a real understanding of what's going on though...
880 + self.PreviewCon troller = SlideController (self.ControlSp litter, False) (self.ControlSp litter, True)
881 + self.LiveController = SlideController
Just a note: I started naming things on forms before we had decided on a standard, so they're a little out of sync with the proper naming convention. I am cleaning them up in a cleanup branch, but just for reference, those two should probably be called "self.previewCo ntroller"
982 + self.Toolbar. addToolbarButto n("Move to top", ":/services/ service_ top.png" , u'ServiceManage r', u'Move to start'), self.onServiceTop)
983 + translate(
Not sure what the difference is between the first and second "move to top" strings is, but the first isn't u''
966 - self.Layout = QtGui.QVBoxLayo ut(self)
967 + self.Layout = QVBoxLayout(self)
Please rather use "from PyQt4 import QtCore, QtGui" as it pollutes the local namespace less. (I'm also cleaning this up in my local cleanup branch).
970 self.Toolbar = OpenLPToolbar(self) self.Toolbar) self.Toolbar)
1002 + self.ThemeComboBox = QComboBox(
1004 + self.ThemeWidget = QWidgetAction(
As noted before, my bad, these should be camelCase not PascalCase - also busy cleaning up in my branch.
Apart from those few minor things, everything looks fine. I'll still have to see these things in action to get a real understanding of what's going on though...
review approve