Code review comment for lp:~trb143/openlp/servicing

+ if type(icon) is QtGui.QIcon:
+ elif type(icon) is types.StringType or type(icon) is
types.UnicodeType:

I think the Right Way is isinstance(). Also, "basestring" matches both str and
unicode strings.

if isinstance(icon, QtGui.QIcon):
elif isinstance(icon, basestring):

 review approve