Code review comment for lp:~trb143/openlp/servicing

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Just a note about making some things a little more Pythonic:

  28 frame = QtGui.QPixmap(self.width, self.height)
  29 self.renderer.set_paint_dest(frame)

  Could be written so:

  28 self.renderer.set_paint_dest(QtGui.QPixmap(self.width, self.height))

The usual style police ;-)

  39 answer=self.renderer.render_lines(main_text, footer_text)

You don't really need BOTH of these? Surely just one can be used? And I prefer the top one, as it adds less pollution to the local namespace (I've noticed this in other code too).

  64 from PyQt4 import QtCore, QtGui
  65 from PyQt4.QtCore import *
  66 from PyQt4.QtGui import *

review: Approve

« Back to merge proposal