Code review comment for lp:~trb143/openlp/reporting

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

1. There's a "csv" module, use it.
2. I should be able to specify the file name, not just where to save it to.
3. Have you tested this with > 1000 songs? How long does it take? Some sort of progress window necessary?
4. You call it a report internally, but you're not very specific for the user. Rather call it a "Song List Report".

More comments inline.

review: Needs Fixing

« Back to merge proposal