OpenLP

Code review comment for lp:~trb143/openlp/bugfixes

  1. bugfixes
  2. Merge into trunk
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Please rename your addHeaderBar functions. I can see two options...

1. Have a single function, named "addHeaderBar", that takes a single parameter, "HeaderBarType" which can be either "HeaderBarType.Start" or "HeaderBarType.End";

2. Have two separate functions, named "addStartHeaderBar" and "addEndHeaderBar"

review: Needs Fixing

« Back to merge proposal