Code review comment for lp:~trb143/openlp/bug_788231

Revision history for this message
Tim Bentley (trb143) wrote :

> Hello,
>
> Why the -1 in line 27? In my tests this makes the results rather inaccurate. I
> tested 30px-74px (certainly not all sizes, but I checked the line count
> predictions and they were all smaller than the actual line count).

line_count is incremented at the start of the loop so it is one line bigger that number of lines that fit on the page

« Back to merge proposal