Code review comment for lp:~trb143/openlp/bug-850254

Revision history for this message
Jonathan Corwin (j-corwin) wrote :

Just looking at httpserver.py, we already have a method /api/display
It currently only supports hide or show.
Can't we just extend it to support 'theme' and 'desktop' too?

I'm also not convinced about just toggling it, this could just cause chaos if both the PC user and remote user do it at the same time as it could just result in a flicker. I think the user should tell the app what he wants to do, and then the app does it, even if the end result is to do nothing.

« Back to merge proposal