Code review comment for lp:~trb143/openlp/bitsandbobs

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Looks much better thanks. Just two comments...

1. When wanting to construct a string, rather use string formatting, like so:

    u':' +self.IconPath+u'_new.png'

   becomes

    u':%s_new.png' % self.IconPath

2. Can we rather use Firefox's agent string, or make up a better one than IE 5.5 ? Also, I
   think urllib/urllib2 might have a default agent string, which might be better.

review: Approve

« Back to merge proposal