Merge lp:~trb143/openlp/audit into lp:openlp

Proposed by Tim Bentley
Status: Merged
Merged at revision: not available
Proposed branch: lp:~trb143/openlp/audit
Merge into: lp:openlp
Diff against target: 215 lines
8 files modified
openlp.pyw (+0/-1)
openlp/plugins/audit/auditplugin.py (+48/-16)
openlp/plugins/audit/lib/classes.py (+0/-1)
openlp/plugins/audit/lib/meta.py (+0/-1)
openlp/plugins/custom/forms/editcustomform.py (+6/-8)
openlp/plugins/presentations/lib/__init__.py (+0/-6)
openlp/plugins/presentations/lib/presentationtab.py (+5/-0)
openlp/plugins/songs/forms/editsongform.py (+1/-1)
To merge this branch: bzr merge lp:~trb143/openlp/audit
Reviewer Review Type Date Requested Status
Jon Tibble (community) Approve
Review via email: mp+12431@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

Amend Audit Menus
Clean up songs and custom
Fix Presentation for Linux users

Revision history for this message
Jon Tibble (meths) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp.pyw'
2--- openlp.pyw 2009-09-20 15:45:33 +0000
3+++ openlp.pyw 2009-09-25 16:30:24 +0000
4@@ -81,7 +81,6 @@
5 self.splash.finish(self.mainWindow)
6 return self.exec_()
7
8-
9 def main():
10 """
11 The main function which parses command line options and then runs
12
13=== modified file 'openlp/plugins/audit/auditplugin.py'
14--- openlp/plugins/audit/auditplugin.py 2009-09-24 04:31:33 +0000
15+++ openlp/plugins/audit/auditplugin.py 2009-09-25 16:30:24 +0000
16@@ -66,25 +66,57 @@
17 The actual **Tools** menu item, so that your actions can
18 use it as their parent.
19 """
20+ self.AuditMenu = QtGui.QMenu(tools_menu)
21+ self.AuditMenu.setObjectName(u'AuditMenu')
22+ self.AuditMenu.setTitle(
23+ translate(u'AuditPlugin', u'&Audit'))
24+ #Audit Delete All
25+ self.AuditDeleteAll = QtGui.QAction(tools_menu)
26+ self.AuditDeleteAll.setText(
27+ translate(u'AuditPlugin', u'Au&dit Delete All'))
28+ self.AuditDeleteAll.setStatusTip(
29+ translate(u'AuditPlugin', u'Deleted all Audit records'))
30+ self.AuditDeleteAll.setObjectName(u'AuditDeleteAll')
31+ #Audit Delete
32+ self.AuditDelete = QtGui.QAction(tools_menu)
33+ self.AuditDelete.setText(
34+ translate(u'AuditPlugin', u'Audit &Delete'))
35+ self.AuditDelete.setStatusTip(
36+ translate(u'AuditPlugin', u'Delete all audit data to sepecified date'))
37+ self.AuditDelete.setObjectName(u'AuditDelete')
38+ #Audit Report
39+ self.AuditReport = QtGui.QAction(tools_menu)
40+ self.AuditReport.setText(
41+ translate(u'AuditPlugin', u'Au&dit &Report'))
42+ self.AuditReport.setStatusTip(
43+ translate(u'AuditPlugin', u'Generate Reports on Audit Data'))
44+ self.AuditReport.setObjectName(u'AuditReport')
45+ #Audit activation
46 AuditIcon = QtGui.QIcon()
47 AuditIcon.addPixmap(QtGui.QPixmap(u':/tools/tools_alert.png'),
48 QtGui.QIcon.Normal, QtGui.QIcon.Off)
49- self.ToolsAuditItem = QtGui.QAction(tools_menu)
50- self.ToolsAuditItem.setIcon(AuditIcon)
51- self.ToolsAuditItem.setCheckable(True)
52- self.ToolsAuditItem.setChecked(False)
53- self.ToolsAuditItem.setText(translate(u'AuditPlugin', u'A&udit'))
54- self.ToolsAuditItem.setStatusTip(
55+ self.AuditStatus = QtGui.QAction(tools_menu)
56+ self.AuditStatus.setIcon(AuditIcon)
57+ self.AuditStatus.setCheckable(True)
58+ self.AuditStatus.setChecked(False)
59+ self.AuditStatus.setText(translate(u'AuditPlugin', u'A&udit Status'))
60+ self.AuditStatus.setStatusTip(
61 translate(u'AuditPlugin', u'Start/Stop live song auditing'))
62- self.ToolsAuditItem.setShortcut(translate(u'AuditPlugin', u'F4'))
63- self.ToolsAuditItem.setObjectName(u'ToolsAuditItem')
64- tools_menu.addSeparator()
65- tools_menu.addAction(self.ToolsAuditItem)
66+ self.AuditStatus.setShortcut(translate(u'AuditPlugin', u'F4'))
67+ self.AuditStatus.setObjectName(u'AuditStatus')
68+ #Add Menus together
69+ tools_menu.addAction(self.AuditMenu.menuAction())
70+ self.AuditMenu.addAction(self.AuditStatus)
71+ self.AuditMenu.addSeparator()
72+ self.AuditMenu.addAction(self.AuditDeleteAll)
73+ self.AuditMenu.addAction(self.AuditDelete)
74+ self.AuditMenu.addSeparator()
75+ self.AuditMenu.addAction(self.AuditReport)
76 # Signals and slots
77- QtCore.QObject.connect(self.ToolsAuditItem,
78+ QtCore.QObject.connect(self.AuditStatus,
79 QtCore.SIGNAL(u'visibilityChanged(bool)'),
80- self.ToolsAuditItem.setChecked)
81- QtCore.QObject.connect(self.ToolsAuditItem,
82+ self.AuditStatus.setChecked)
83+ QtCore.QObject.connect(self.AuditStatus,
84 QtCore.SIGNAL(u'triggered(bool)'),
85 self.toggleAuditState)
86
87@@ -100,7 +132,7 @@
88 QtCore.SIGNAL(u'audit_changed'), self.onUpdateAudit)
89 self.auditActive = str_to_bool(
90 self.config.get_config(u'audit active', False))
91- self.ToolsAuditItem.setChecked(self.auditActive)
92+ self.AuditStatus.setChecked(self.auditActive)
93 self.auditmanager = AuditManager(self.config)
94
95 def toggleAuditState(self):
96@@ -130,5 +162,5 @@
97 """
98 self.auditActive = str_to_bool(
99 self.config.get_config(u'audit active', False))
100-# self.ToolsAuditItem.setChecked(self.auditActive)
101- self.ToolsAuditItem.setEnabled(True)
102+# self.AuditStatus.setChecked(self.auditActive)
103+ self.AuditStatus.setEnabled(True)
104
105=== modified file 'openlp/plugins/audit/lib/classes.py'
106--- openlp/plugins/audit/lib/classes.py 2009-09-24 04:32:24 +0000
107+++ openlp/plugins/audit/lib/classes.py 2009-09-25 16:30:24 +0000
108@@ -22,7 +22,6 @@
109 # Temple Place, Suite 330, Boston, MA 02111-1307 USA #
110 ###############################################################################
111
112-
113 class BaseModel(object):
114 """
115 BaseModel provides a base object with a set of generic functions
116
117=== modified file 'openlp/plugins/audit/lib/meta.py'
118--- openlp/plugins/audit/lib/meta.py 2009-09-25 00:43:42 +0000
119+++ openlp/plugins/audit/lib/meta.py 2009-09-25 16:30:24 +0000
120@@ -22,7 +22,6 @@
121 # Temple Place, Suite 330, Boston, MA 02111-1307 USA #
122 ###############################################################################
123
124-
125 from sqlalchemy import MetaData
126
127 __all__ = ['session', 'metadata', 'engine']
128
129=== modified file 'openlp/plugins/custom/forms/editcustomform.py'
130--- openlp/plugins/custom/forms/editcustomform.py 2009-09-25 00:43:42 +0000
131+++ openlp/plugins/custom/forms/editcustomform.py 2009-09-25 16:30:24 +0000
132@@ -200,7 +200,7 @@
133 def onSaveButtonPressed(self):
134 if self.editAll:
135 self.VerseListView.clear()
136- for row in unicode(self.VerseTextEdit.toPlainText()).split(u'---'):
137+ for row in unicode(self.VerseTextEdit.toPlainText()).split(u'\n---\n'):
138 self.VerseListView.addItem(row)
139 else:
140 self.VerseListView.currentItem().setText(
141@@ -227,15 +227,13 @@
142 self.EditAllButton.setEnabled(True)
143
144 def _validate(self):
145- valid = True
146- message = u''
147 if len(self.TitleEdit.displayText()) == 0:
148- valid = False
149- message = translate(
150+ self.TitleEdit.setFocus()
151+ return False, translate(
152 u'customEditDialog', u'You need to enter a title \n')
153 # must have 1 slide
154 if self.VerseListView.count() == 0:
155- valid = False
156- message += translate(
157+ self.VerseTextEdit.setFocus()
158+ return False, translate(
159 u'customEditDialog', u'You need to enter a slide \n')
160- return valid, message
161+ return True, u''
162
163=== modified file 'openlp/plugins/presentations/lib/__init__.py'
164--- openlp/plugins/presentations/lib/__init__.py 2009-09-24 20:56:13 +0000
165+++ openlp/plugins/presentations/lib/__init__.py 2009-09-25 16:30:24 +0000
166@@ -31,9 +31,3 @@
167 from messagelistener import MessageListener
168 from mediaitem import PresentationMediaItem
169 from presentationtab import PresentationTab
170-
171-__all__ = ['PresentationMediaItem', 'PresentationTab',
172- 'ImpressController', 'MessageListener']
173-if os.name == u'nt':
174- __all__.append('PptviewController')
175- #__all__.append('PowerpointController');
176
177=== modified file 'openlp/plugins/presentations/lib/presentationtab.py'
178--- openlp/plugins/presentations/lib/presentationtab.py 2009-09-25 00:43:42 +0000
179+++ openlp/plugins/presentations/lib/presentationtab.py 2009-09-25 16:30:24 +0000
180@@ -22,6 +22,7 @@
181 # Temple Place, Suite 330, Boston, MA 02111-1307 USA #
182 ###############################################################################
183
184+import os
185 from PyQt4 import QtGui
186
187 from openlp.core.lib import SettingsTab, translate
188@@ -60,11 +61,15 @@
189 self.VerseTypeLayout.setObjectName(u'VerseTypeLayout')
190 self.PowerpointCheckBox = QtGui.QCheckBox(self.VerseDisplayGroupBox)
191 self.PowerpointCheckBox.setTristate(False)
192+ if os.name != u'nt':
193+ self.PowerpointCheckBox.setEnabled(False)
194 self.PowerpointCheckBox.setObjectName(u'PowerpointCheckBox')
195 self.VerseDisplayLayout.addWidget(self.PowerpointCheckBox, 0, 0, 1, 1)
196 self.PowerpointViewerCheckBox = QtGui.QCheckBox(
197 self.VerseDisplayGroupBox)
198 self.PowerpointViewerCheckBox.setTristate(False)
199+ if os.name != u'nt':
200+ self.PowerpointViewerCheckBox.setEnabled(False)
201 self.PowerpointViewerCheckBox.setObjectName(u'PowerpointViewerCheckBox')
202 self.VerseDisplayLayout.addWidget(
203 self.PowerpointViewerCheckBox, 1, 0, 1, 1)
204
205=== modified file 'openlp/plugins/songs/forms/editsongform.py'
206--- openlp/plugins/songs/forms/editsongform.py 2009-09-25 00:43:42 +0000
207+++ openlp/plugins/songs/forms/editsongform.py 2009-09-25 16:30:24 +0000
208@@ -334,7 +334,7 @@
209 verse_list = self.verse_form.getVerse()
210 verse_list = verse_list.replace(u'\r\n', u'\n')
211 self.VerseListWidget.clear()
212- for row in verse_list.split(u'---'):
213+ for row in verse_list.split(u'\n---\n'):
214 self.VerseListWidget.addItem(row)
215 self.VerseListWidget.repaint()
216