Merge lp:~trb143/openlp/audit into lp:openlp

Proposed by Tim Bentley
Status: Merged
Merged at revision: not available
Proposed branch: lp:~trb143/openlp/audit
Merge into: lp:openlp
Diff against target: 76 lines
5 files modified
openlp/plugins/audit/auditplugin.py (+3/-11)
openlp/plugins/audit/lib/classes.py (+1/-0)
openlp/plugins/audit/lib/meta.py (+1/-0)
openlp/plugins/audit/lib/tables.py (+2/-1)
openlp/plugins/songs/lib/mediaitem.py (+1/-1)
To merge this branch: bzr merge lp:~trb143/openlp/audit
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
Review via email: mp+12326@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

Fix up audit database with copyright
Fix runtime errors from last merge.

This merge requires you to delete your audit database!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

What's with the extra line in classes.py and meta.py?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/plugins/audit/auditplugin.py'
2--- openlp/plugins/audit/auditplugin.py 2009-09-23 17:36:22 +0000
3+++ openlp/plugins/audit/auditplugin.py 2009-09-24 04:55:20 +0000
4@@ -116,7 +116,8 @@
5 audititem.auditdate = datetime.today()
6 audititem.audittime = datetime.now().time()
7 audititem.title = auditData[0]
8- audititem.ccl_id = auditData[2]
9+ audititem.copyright = auditData[2]
10+ audititem.ccl_number = auditData[3]
11 audititem.authors = u''
12 for author in auditData[1]:
13 audititem.authors += author + u' '
14@@ -129,14 +130,5 @@
15 """
16 self.auditActive = str_to_bool(
17 self.config.get_config(u'audit active', False))
18- if self.auditFileNameNew == u'':
19- self.auditActive = False
20- self.ToolsAuditItem.setChecked(self.auditActive)
21- self.ToolsAuditItem.setEnabled(False)
22- return
23+# self.ToolsAuditItem.setChecked(self.auditActive)
24 self.ToolsAuditItem.setEnabled(True)
25- if self.auditFileNameNew != self.auditFileName:
26- if self.auditFile is not None:
27- self.auditFile.close()
28- self.auditFile = open(self.auditFileNameNew, u'a')
29-
30
31=== modified file 'openlp/plugins/audit/lib/classes.py'
32--- openlp/plugins/audit/lib/classes.py 2009-09-23 15:51:03 +0000
33+++ openlp/plugins/audit/lib/classes.py 2009-09-24 04:55:20 +0000
34@@ -22,6 +22,7 @@
35 # Temple Place, Suite 330, Boston, MA 02111-1307 USA #
36 ###############################################################################
37
38+
39 class BaseModel(object):
40 """
41 BaseModel provides a base object with a set of generic functions
42
43=== modified file 'openlp/plugins/audit/lib/meta.py'
44--- openlp/plugins/audit/lib/meta.py 2009-09-22 19:37:36 +0000
45+++ openlp/plugins/audit/lib/meta.py 2009-09-24 04:55:20 +0000
46@@ -22,6 +22,7 @@
47 # Temple Place, Suite 330, Boston, MA 02111-1307 USA #
48 ###############################################################################
49
50+
51 from sqlalchemy import MetaData
52 from sqlalchemy.orm import scoped_session, sessionmaker
53
54
55=== modified file 'openlp/plugins/audit/lib/tables.py'
56--- openlp/plugins/audit/lib/tables.py 2009-09-23 16:33:30 +0000
57+++ openlp/plugins/audit/lib/tables.py 2009-09-24 04:55:20 +0000
58@@ -33,5 +33,6 @@
59 Column(u'audittime', types.Time, index=True, nullable=False),
60 Column(u'title', types.Unicode(255), nullable=False),
61 Column(u'authors', types.Unicode(255), nullable=False),
62- Column(u'ccl_id', types.Unicode(65), nullable=False)
63+ Column(u'copyright', types.Unicode(255)),
64+ Column(u'ccl_number', types.Unicode(65))
65 )
66
67=== modified file 'openlp/plugins/songs/lib/mediaitem.py'
68--- openlp/plugins/songs/lib/mediaitem.py 2009-09-21 17:56:36 +0000
69+++ openlp/plugins/songs/lib/mediaitem.py 2009-09-24 04:55:20 +0000
70@@ -308,5 +308,5 @@
71 raw_footer.append(unicode(
72 translate(u'SongMediaItem', u'CCL Licence: ') + ccl))
73 service_item.raw_footer = raw_footer
74- service_item.audit = [service_item.title, author_audit, ccl]
75+ service_item.audit = [song.title, author_audit, song.copyright, song.ccli_number]
76 return True