Code review comment for lp:~trb143/openlp/audit

Revision history for this message
Jonathan Corwin (j-corwin) wrote :

I haven't looked too closely, but it looks like you're outputting to a comma separated list.
E.g.
openlp/plugins/songs/lib/mediaitem.py
  service_item.audit = u'%s,%s,%s' % (service_item.title, author_list, ccl)

I expect the title and author_list could potentially contain commas also, so it could probably do with quoting the fields, something like the following, unless this is handled elsewhere?

service_item.audit = u'"%s","%s",%s' % (service_item.title.replace(u'"', u'""'), author_list.replace(u'"', u'""'), ccl)

« Back to merge proposal