Code review comment for lp:~trb143/openlp/ThemeManager2

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

If you wanted to, you could make the __init__ function of ThemeXML take named parameters so that it's a little cooler, like so:

  theme = ThemeXML(parse=theme_xml)

It would cut 2 lines down to 1. Just a nice-to-have though.

review: Approve

« Back to merge proposal