Code review comment for ~travisghansen/maas:master
Revision history for this message
| Travis Glenn Hansen (travisghansen) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Thanks for the review!
1. I considered this but figured it could be managed via the GET/query params within the URL itself.
2. I'll see what I can put together for that. Trying to setup a development environment has been...challenging. Even worse is trying to inject the code into a snap :( so testing for me generally has been quite challenging.
3. I based it on the code from recs.py which is using urllib
It would be great if you could twistify it as I'm sure I'll mess something up with the async/await stuff especially given how hard it is for me to *really* test changes. Is there a doc somewhere with instructions for running locally and what services are needed etc? Preferably something that is OS independent since I don't run ubuntu on my workstation.