Code review comment for ~travisghansen/maas:master

Revision history for this message
Adam Collard (adam-collard) wrote :

Thanks for the contribution!

I haven't looked at the code per se but wanted to share output from the CI job:

ERROR: /run/build/maas/src/provisioningserver/drivers/power/webhook.py Imports are incorrectly sorted.
 --- /run/build/maas/src/provisioningserver/drivers/power/webhook.py:before 2021-01-04 19:19:49.596325
 +++ /run/build/maas/src/provisioningserver/drivers/power/webhook.py:after 2021-01-04 19:22:47.812771
 @@ -11,13 +11,13 @@
  import urllib.request

  from provisioningserver.drivers import make_ip_extractor, make_setting_field
 -from provisioningserver.logger import get_maas_logger
  from provisioningserver.drivers.power import (
      PowerActionError,
      PowerConnError,
      PowerDriver,
      PowerFatalError,
  )
 +from provisioningserver.logger import get_maas_logger

  maaslog = get_maas_logger("drivers.power.webhook")

 make: *** [Makefile:213: lint-py] Error 1

« Back to merge proposal