Merge lp:~trapnine/maas/fix-1499062 into lp:~maas-committers/maas/trunk
Proposed by
Jeffrey C Jones
Status: | Merged |
---|---|
Approved by: | Jeffrey C Jones |
Approved revision: | no longer in the source branch. |
Merged at revision: | 4389 |
Proposed branch: | lp:~trapnine/maas/fix-1499062 |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
102 lines (+50/-2) 3 files modified
src/maasserver/fields.py (+8/-0) src/maasserver/forms.py (+3/-2) src/maasserver/tests/test_forms_settings.py (+39/-0) |
To merge this branch: | bzr merge lp:~trapnine/maas/fix-1499062 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Blake Rouse (community) | Approve | ||
Review via email: mp+274980@code.launchpad.net |
Commit message
Fix lp:1499062. Use URLField for boot_source_url, strip whitespace on boot_source_keyring in BootSourceSetti
To post a comment you must log in.
Code itself looks good. The unit testing needs to be improved. Overall you have good coverage just the format and how the tests are being done need to be improved. Comments inline about the testing.