Code review comment for lp:~tr3buchet/nova/multi_nic

Revision history for this message
Trey Morris (tr3buchet) wrote :

> 2. One unit test fail.
> ======================================================================
> ERROR: test_spawn_with_network_info
> (nova.tests.test_libvirt.LibvirtConnTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/opt2/multi_nic/nova/tests/test_libvirt.py", line 767, in
> test_spawn_with_network_info
> 'mac': instance['mac_address'],
> File "/opt2/multi_nic/nova/db/sqlalchemy/models.py", line 74, in __getitem__
> return getattr(self, key)
> AttributeError: 'Instance' object has no attribute 'mac_address'
> -------------------- >> begin captured logging << --------------------
> 2011-06-28 16:53:10,139 AUDIT nova.auth.manager [-] Created user fake (admin:
> True)
> 2011-06-28 16:53:10,140 DEBUG nova.ldapdriver [-] Local cache hit for
> __project_to_dn by key pid_dn-fake from (pid=1113) inner
> /opt2/multi_nic/nova/auth/ldapdriver.py:153
> 2011-06-28 16:53:10,140 DEBUG nova.ldapdriver [-] Local cache hit for
> __dn_to_uid by key dn_uid-uid=fake,ou=Users,dc=example,dc=com from (pid=1113)
> inner /opt2/multi_nic/nova/auth/ldapdriver.py:153
> 2011-06-28 16:53:10,141 AUDIT nova.auth.manager [-] Created project fake with
> manager fake
> --------------------- >> end captured logging << ---------------------
>

Went ahead and skipped this test since it needs to be rewritten.

Should be good to go. merging trunk again.

« Back to merge proposal