Code review comment for lp:~tr3buchet/nova/multi_nic

Trey,

Thank you for fixing problems.

Could you check following two points?

1. Cannot run tests.
# ./run_tests.sh
ERROR

======================================================================
ERROR: <nose.suite.ContextSuite context=nova.tests>
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt2/nova/.nova-venv/lib/python2.6/site-packages/nose/suite.py", line 208, in run
    self.setUp()
  File "/opt2/nova/.nova-venv/lib/python2.6/site-packages/nose/suite.py", line 291, in setUp
    self.setupContext(ancestor)
  File "/opt2/nova/.nova-venv/lib/python2.6/site-packages/nose/suite.py", line 314, in setupContext
    try_run(context, names)
  File "/opt2/nova/.nova-venv/lib/python2.6/site-packages/nose/util.py", line 478, in try_run
    return func()
  File "/opt2/multi_nic/nova/tests/__init__.py", line 69, in setup
    vlan_start=FLAGS.vlan_start)
  File "/opt2/multi_nic/nova/network/manager.py", line 852, in create_networks
    NetworkManager.create_networks(self, context, vpn=True, **kwargs)
  File "/opt2/multi_nic/nova/network/manager.py", line 585, in create_networks
    net['gateway_v6'] = str(list(project_net_v6)[1])
  File "/opt2/nova/.nova-venv/lib/python2.6/site-packages/netaddr/ip/__init__.py", line 932, in __len__
    "IP addresses! Use the .size property instead." % _sys.maxint)
IndexError: range contains more than 9223372036854775807 (sys.maxint) IP addresses! Use the .size property instead.
-------------------- >> begin captured logging << --------------------

I think this is bug of trunk originally. I reported. https://bugs.launchpad.net/nova/+bug/802849

2. One unit test fail.
======================================================================
ERROR: test_spawn_with_network_info (nova.tests.test_libvirt.LibvirtConnTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt2/multi_nic/nova/tests/test_libvirt.py", line 767, in test_spawn_with_network_info
    'mac': instance['mac_address'],
  File "/opt2/multi_nic/nova/db/sqlalchemy/models.py", line 74, in __getitem__
    return getattr(self, key)
AttributeError: 'Instance' object has no attribute 'mac_address'
-------------------- >> begin captured logging << --------------------
2011-06-28 16:53:10,139 AUDIT nova.auth.manager [-] Created user fake (admin: True)
2011-06-28 16:53:10,140 DEBUG nova.ldapdriver [-] Local cache hit for __project_to_dn by key pid_dn-fake from (pid=1113) inner /opt2/multi_nic/nova/auth/ldapdriver.py:153
2011-06-28 16:53:10,140 DEBUG nova.ldapdriver [-] Local cache hit for __dn_to_uid by key dn_uid-uid=fake,ou=Users,dc=example,dc=com from (pid=1113) inner /opt2/multi_nic/nova/auth/ldapdriver.py:153
2011-06-28 16:53:10,141 AUDIT nova.auth.manager [-] Created project fake with manager fake
--------------------- >> end captured logging << ---------------------

Thanks,