Code review comment for lp:~tr3buchet/nova/multi_nic
Revision history for this message
| Trey Morris (tr3buchet) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
If libvirt had worked successfully I would have been surprised. The only hypervisor I supported in this patch was xen.
If it comes to moving some of the information in the network_info tuple from the info portion to the network portion, I can do that, but I won't have it existing in both. The original idea was for network to be the network db object and for info to be the info an instance might need to configure networking. And then passing around network objects failed when going through rpc. What I would prefer is if the relevant areas of libvirt would refer to the info portion of the tuple. That is unless there is disagreement in the way I've set up the network_info tuple, which would require more drastic change.
As for network delete, Dan can you make a paste of your virtual interfaces and networks tables for me?