Merge lp:~tplavcic/percona-server/bug1314568-5.1 into lp:percona-server/5.1

Proposed by Tomislav Plavcic
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 615
Proposed branch: lp:~tplavcic/percona-server/bug1314568-5.1
Merge into: lp:percona-server/5.1
Diff against target: 13 lines (+3/-1)
1 file modified
build/build-binary.sh (+3/-1)
To merge this branch: bzr merge lp:~tplavcic/percona-server/bug1314568-5.1
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+221018@code.launchpad.net

This proposal supersedes a proposal from 2014-05-26.

Description of the change

Initialised variable COMMON_FLAGS which was set only on centos so the script refused to run on Ubuntu

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote : Posted in a previous version of this proposal

COMMON_FLAGS does not appear to be used in 5.1?

review: Disapprove
Revision history for this message
Tomislav Plavcic (tplavcic) wrote :

Changed commit message, linked commit to bug, COMMON_FLAGS is defined in the trunk but just not in GCA versions

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'build/build-binary.sh'
--- build/build-binary.sh 2014-03-12 22:02:31 +0000
+++ build/build-binary.sh 2014-05-27 06:42:57 +0000
@@ -17,7 +17,9 @@
17TARGET_CFLAGS=''17TARGET_CFLAGS=''
18WITH_SSL='/usr'18WITH_SSL='/usr'
19TAG=''19TAG=''
2020#
21COMMON_FLAGS=''
22#
21# Some programs that may be overriden23# Some programs that may be overriden
22TAR=${TAR:-tar}24TAR=${TAR:-tar}
2325

Subscribers

People subscribed via source and target branches