Code review comment for lp:~tplavcic/percona-server/bld-212-5.6-tokudb

Revision history for this message
Roel Van de Paar (roel11) wrote :

However, the way it stands now;

+ echo -e " * Run the following script to enable the TokuDB storage engine in Percona Server:\n"
+ echo -e "\tps_tokudb_admin --enable -u <mysql_admin_user> -p <mysql_admin_pass>\n"
+ echo -e " * See http://www.percona.com/doc/percona-server/5.6/tokudb/tokudb_intro.html for more details\n\n"

It looks like tokudb_intro.html will have more details on tps_tokudb_admin (it does not). Maybe instead it should be pointed at http://www.percona.com/doc/percona-server/5.6/tokudb/tokudb_installation.html and on that page (before we release this) info on tps_tokudb_admin.sh should be added.

Btw, the above should read" ps_tokudb_admin.sh" (.sh) + potentially list connect details? How about;

+ echo -e "\tps_tokudb_admin --enable -u <mysql_admin_user> -p <mysql_admin_pass> {-S <socket>} {-h <host> -P <port>} \n"

« Back to merge proposal