Merge lp:~tpeeters/unity8/new_tabbar-again into lp:unity8
Proposed by
Tim Peeters
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | 833 |
Merged at revision: | 870 |
Proposed branch: | lp:~tpeeters/unity8/new_tabbar-again |
Merge into: | lp:unity8 |
Diff against target: |
52 lines (+19/-11) 1 file modified
qml/Dash/DashContent.qml (+19/-11) |
To merge this branch: | bzr merge lp:~tpeeters/unity8/new_tabbar-again |
Related bugs: | |
Related blueprints: |
New header and bottom edge
(Essential)
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Peeters (community) | Approve | ||
Albert Astals Cid (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email: mp+215658@code.launchpad.net |
Commit message
Adapt to new TabBar
Description of the change
Re-do the changes (r820) to move the selectedIndex from the TabBar to the tabs model.
* Are there any related MPs required for this MP to build/function as expected?
https:/
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
FAILED: Continuous integration, rev:833 jenkins. qa.ubuntu. com/job/ unity8- ci/2810/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- trusty- touch/228 jenkins. qa.ubuntu. com/job/ generic- mediumtests- trusty/ 4820 jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- trusty/ 1674 jenkins. qa.ubuntu. com/job/ unity8- trusty- amd64-ci/ 1331 jenkins. qa.ubuntu. com/job/ unity8- trusty- armhf-ci/ 1335 jenkins. qa.ubuntu. com/job/ unity8- trusty- armhf-ci/ 1335/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity8- trusty- i386-ci/ 1331 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- mako/215 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- armhf/4397 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- armhf/4397/ artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 6000 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-trusty/ 4165 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- amd64/4952 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- amd64/4952/ artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/2810/ rebuild
http://