Merge lp:~tpeeters/ubuntu-ui-toolkit/use-new-divider into lp:ubuntu-ui-toolkit/staging

Proposed by Tim Peeters
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1347
Merged at revision: 1349
Proposed branch: lp:~tpeeters/ubuntu-ui-toolkit/use-new-divider
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 79 lines (+1/-47)
3 files modified
modules/Ubuntu/Components/Themes/Ambiance/HeadSeparatorImageStyle.qml (+0/-36)
modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml (+1/-10)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+0/-1)
To merge this branch: bzr merge lp:~tpeeters/ubuntu-ui-toolkit/use-new-divider
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+242794@code.launchpad.net

Commit message

Remove the old header separator style.

Description of the change

Remove the old header separator style.

Accidentally in PageHeadStyle, useOldDivider was already set to false (should have been true until unity8 was updated), so the old separator style was never used.

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

nice cleanup

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1347. By Tim Peeters

put back ghe artwork

Revision history for this message
Tim Peeters (tpeeters) wrote :

Added the artwork again. It is still used by the old HeaderStyle when we have MainView.useDeprecatedToolbar: true.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== removed file 'modules/Ubuntu/Components/Themes/Ambiance/HeadSeparatorImageStyle.qml'
--- modules/Ubuntu/Components/Themes/Ambiance/HeadSeparatorImageStyle.qml 2014-10-24 13:13:11 +0000
+++ modules/Ubuntu/Components/Themes/Ambiance/HeadSeparatorImageStyle.qml 1970-01-01 00:00:00 +0000
@@ -1,36 +0,0 @@
1/*
2 * Copyright 2014 Canonical Ltd.
3 *
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU Lesser General Public License as published by
6 * the Free Software Foundation; version 3.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU Lesser General Public License for more details.
12 *
13 * You should have received a copy of the GNU Lesser General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */
16import QtQuick 2.2
17
18// This is the old DEPRECATED header separator, which is here for backwards compatibility.
19// The new header divider is in HeadDividerStyle.qml.
20Item {
21 id: separatorStyle
22 BorderImage {
23 id: separatorImage
24 anchors.fill: parent
25 source: styledItem.separatorSource
26 }
27 Image {
28 id: separatorBottom
29 anchors {
30 top: separatorImage.bottom
31 left: parent.left
32 right: parent.right
33 }
34 source: styledItem.separatorBottomSource
35 }
36}
370
=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml'
--- modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml 2014-11-17 18:45:05 +0000
+++ modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml 2014-11-26 20:10:50 +0000
@@ -23,10 +23,6 @@
23 id: headerStyle23 id: headerStyle
24 objectName: "PageHeadStyle" // used in unit tests24 objectName: "PageHeadStyle" // used in unit tests
25 contentHeight: units.gu(7)25 contentHeight: units.gu(7)
26 // FIXME: After After https://code.launchpad.net/~mzanetti/unity8/new-pageheader-api/+merge/239242
27 // lands, set separatorSource and separatorBottomSource to "" in order to use the new divider.
28 separatorSource: "artwork/PageHeaderBaseDividerLight.sci"
29 separatorBottomSource: "artwork/PageHeaderBaseDividerBottom.png"
30 fontWeight: Font.Light26 fontWeight: Font.Light
31 fontSize: "x-large"27 fontSize: "x-large"
32 textLeftMargin: units.gu(2)28 textLeftMargin: units.gu(2)
@@ -105,12 +101,7 @@
105 // backgroundColor is used in the new HeadDividerStyle101 // backgroundColor is used in the new HeadDividerStyle
106 property color backgroundColor: styledItem.dividerColor102 property color backgroundColor: styledItem.dividerColor
107103
108 // FIXME: After https://code.launchpad.net/~mzanetti/unity8/new-pageheader-api/+merge/239242104 style: Theme.createStyleComponent("HeadDividerStyle.qml", divider)
109 // lands, set the value of useOldDivider to: "" != separatorSource
110 property bool useOldDivider: false
111
112 style: useOldDivider ? Theme.createStyleComponent("HeadSeparatorImageStyle.qml", divider)
113 : Theme.createStyleComponent("HeadDividerStyle.qml", divider)
114105
115 property PageHeadSections sections: styledItem.config.sections106 property PageHeadSections sections: styledItem.config.sections
116107
117108
=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/qmldir'
--- modules/Ubuntu/Components/Themes/Ambiance/qmldir 2014-11-10 17:08:05 +0000
+++ modules/Ubuntu/Components/Themes/Ambiance/qmldir 2014-11-26 20:10:50 +0000
@@ -53,5 +53,4 @@
53internal TextSelectionStartCursorStyle TextSelectionStartCursorStyle.qml53internal TextSelectionStartCursorStyle TextSelectionStartCursorStyle.qml
54internal TextSelectionEndCursorStyle TextSelectionEndCursorStyle.qml54internal TextSelectionEndCursorStyle TextSelectionEndCursorStyle.qml
55internal OverflowPanel OverflowPanel.qml55internal OverflowPanel OverflowPanel.qml
56internal HeadSeparatorImageStyle HeadSeparatorImageStyle.qml
57internal HeadDividerStyle HeadDividerStyle.qml56internal HeadDividerStyle HeadDividerStyle.qml

Subscribers

People subscribed via source and target branches