Code review comment for lp:~tpeeters/ubuntu-ui-toolkit/stack-tabs

Revision history for this message
Cris Dywan (kalikiana) wrote :

"Please note that when a \l PageStack exists inside Tabs, the Tabs will remain active and thus control the header, even when a new \l Page is pushed to the internal \l PageStack."

I'm wondering if that section could be a little more actionable, say "You need to push()/pop() explicitly to switch to the page in that case".

Looks good in any case. I like that the real fix is so simple.

review: Approve

« Back to merge proposal