Code review comment for lp:~tpeeters/ubuntu-ui-toolkit/panel

Revision history for this message
Zsombor Egri (zsombi) wrote :

> > 183 + \li Qt.AlignLeft to swipe in the panel from the left
> > 184 + \li Qt.AlignRight to swipe in the panel from the right
> >
> > Think about LTR/RTL, thus AlignLeading/AlignTrailing would be more
> suitable...
>
> The developer still needs to set the anchors himself, and align only specifies
> which direction to swipe inside the edge of the area of the Panel to show/hide
> the panel. So, when going from LTR to RTL, the anchors would also need to be
> updated and it would only be confusing if the swiping direction would change
> when the anchors don't change automatically.
>
> An example of why the anchors are not automatic, is this Panel (it is in the
> examples from documentation):
> Panel {
> anchors {
> right: parent.right
> bottom: parent.bottom
> top: parent.top
> }
> width: parent.width / 2
> }
>
> This can be aligned top, bottom or right, which only defines the swiping
> direction, not the location of the panel when it is active.

Well, if you anchor an item to left on LTR, it will be anchored to right on RTL if I'm not mistaken :) so in that sense my comments are right.

« Back to merge proposal