Code review comment for lp:~tpeeters/ubuntu-ui-toolkit/lessHeaderDisabling

Revision history for this message
Tim Peeters (tpeeters) wrote :

Yes, I used this program to test it: http://paste.ubuntu.com/13319267/

When the contents height of the flickable is changed, and the new content height is smaller than the flickable height (so scrolling is no longer possible), header.show() is called in UCHeader.cpp in order to avoid getting in a state where the header is hidden while you cannot scroll the flickable to reveal it again. Only in this case that is not needed because the header was already visible, but still show() sets the moving property to true for just an instance, and when moving, the contents of the header is disabled (to avoid tapping a button by accident while the header moves). That is now avoided with my changes.

« Back to merge proposal