Code review comment for lp:~tpeeters/ubuntu-ui-toolkit/headerHeightInit

Revision history for this message
Cris Dywan (kalikiana) wrote :

How about instead of moving the alignment test inside an Item, add a second one, to actually test that both behave the same?

And for the page test flickableY + header.height is expected now instead of just flickableY, I wonder if headerHeight can be checked also here to know the value is right? Since the existing case should not have changed but the test doesn't check.

review: Needs Information

« Back to merge proposal