Merge lp:~tpeeters/ubuntu-ui-toolkit/gallery-app-warnings into lp:ubuntu-ui-toolkit
- gallery-app-warnings
- Merge into trunk
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Francis Ginther | ||||||||
Approved revision: | 750 | ||||||||
Merged at revision: | 753 | ||||||||
Proposed branch: | lp:~tpeeters/ubuntu-ui-toolkit/gallery-app-warnings | ||||||||
Merge into: | lp:ubuntu-ui-toolkit | ||||||||
Diff against target: |
38 lines (+14/-3) 2 files modified
modules/Ubuntu/Components/MainView.qml (+6/-1) modules/Ubuntu/Components/Page.qml (+8/-2) |
||||||||
To merge this branch: | bzr merge lp:~tpeeters/ubuntu-ui-toolkit/gallery-app-warnings | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Tim Peeters | Approve | ||
Zsombor Egri | Approve | ||
Review via email: mp+184788@code.launchpad.net |
Commit message
Fix warnings when running gallery-app autopilot tests.
Description of the change
Fix warnings when running gallery-app autopilot tests.
Tim Peeters (tpeeters) wrote : | # |
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:748
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Tim Peeters (tpeeters) wrote : | # |
I ran the gallery-app autopilot tests of this MR on device together with the gallery-app version of this MR https:/
Tim Peeters (tpeeters) wrote : | # |
Autopilot tests PASSED for gallery_app, webbrowser_app and notes_app for stable image 20130910.2 on device with the above UITK packages installed.
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
Tim Peeters (tpeeters) wrote : | # |
trying again to see how random the autolanding results are :s
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
Tim Peeters (tpeeters) wrote : | # |
apparently there was a bug in unity that prevented app interaction, which causes the tests to fail. re-happroving to see if it is fixed now.
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:749
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
FAILURE: http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:750
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
Click here to trigger a rebuild:
http://
Cris Dywan (kalikiana) wrote : | # |
Affected by bug 1229110
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
Francis Ginther (fginther) wrote : | # |
Made changes to ci test runners and pulled back the unity8 tests.
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
PS Jenkins bot (ps-jenkins) : | # |
Preview Diff
1 | === modified file 'modules/Ubuntu/Components/MainView.qml' | |||
2 | --- modules/Ubuntu/Components/MainView.qml 2013-08-22 17:15:35 +0000 | |||
3 | +++ modules/Ubuntu/Components/MainView.qml 2013-09-23 08:52:24 +0000 | |||
4 | @@ -247,7 +247,12 @@ | |||
5 | 247 | clip: headerItem.bottomY > 0 && activePage && activePage.flickable | 247 | clip: headerItem.bottomY > 0 && activePage && activePage.flickable |
6 | 248 | && -activePage.flickable.contentY < headerItem.bottomY | 248 | && -activePage.flickable.contentY < headerItem.bottomY |
7 | 249 | 249 | ||
9 | 250 | property Page activePage: mainView.activeLeafNode | 250 | property Page activePage: isPage(mainView.activeLeafNode) ? mainView.activeLeafNode : null |
10 | 251 | |||
11 | 252 | function isPage(item) { | ||
12 | 253 | return item.hasOwnProperty("__isPageTreeNode") && item.__isPageTreeNode && | ||
13 | 254 | item.hasOwnProperty("title") && item.hasOwnProperty("tools"); | ||
14 | 255 | } | ||
15 | 251 | 256 | ||
16 | 252 | Item { | 257 | Item { |
17 | 253 | id: contents | 258 | id: contents |
18 | 254 | 259 | ||
19 | === modified file 'modules/Ubuntu/Components/Page.qml' | |||
20 | --- modules/Ubuntu/Components/Page.qml 2013-08-22 17:08:11 +0000 | |||
21 | +++ modules/Ubuntu/Components/Page.qml 2013-09-23 08:52:24 +0000 | |||
22 | @@ -151,8 +151,14 @@ | |||
23 | 151 | UnityActions.ActionContext { | 151 | UnityActions.ActionContext { |
24 | 152 | id: actionContext | 152 | id: actionContext |
25 | 153 | 153 | ||
28 | 154 | Component.onCompleted: { | 154 | property var actionManager: page.__propagated && |
29 | 155 | var manager = page.__propagated.actionManager; | 155 | page.__propagated.hasOwnProperty("actionManager") ? |
30 | 156 | page.__propagated.actionManager : null | ||
31 | 157 | |||
32 | 158 | onActionManagerChanged: addLocalContext(actionManager) | ||
33 | 159 | Component.onCompleted: addLocalContext(actionManager) | ||
34 | 160 | |||
35 | 161 | function addLocalContext(manager) { | ||
36 | 156 | if (manager) manager.addLocalContext(actionContext); | 162 | if (manager) manager.addLocalContext(actionContext); |
37 | 157 | } | 163 | } |
38 | 158 | } | 164 | } |
UITK 'make check' and autopilot tests passed on PC.