Merge lp:~tpeeters/ubuntu-ui-toolkit/gallery-app-warnings into lp:ubuntu-ui-toolkit

Proposed by Tim Peeters
Status: Merged
Approved by: Francis Ginther
Approved revision: 750
Merged at revision: 753
Proposed branch: lp:~tpeeters/ubuntu-ui-toolkit/gallery-app-warnings
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 38 lines (+14/-3)
2 files modified
modules/Ubuntu/Components/MainView.qml (+6/-1)
modules/Ubuntu/Components/Page.qml (+8/-2)
To merge this branch: bzr merge lp:~tpeeters/ubuntu-ui-toolkit/gallery-app-warnings
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Approve
Zsombor Egri Approve
Review via email: mp+184788@code.launchpad.net

Commit message

Fix warnings when running gallery-app autopilot tests.

Description of the change

Fix warnings when running gallery-app autopilot tests.

To post a comment you must log in.
Revision history for this message
Tim Peeters (tpeeters) wrote :

UITK 'make check' and autopilot tests passed on PC.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

I ran the gallery-app autopilot tests of this MR on device together with the gallery-app version of this MR https://code.launchpad.net/~amanzi-team/gallery-app/gallery-app-actions-api/+merge/184533 and they all PASSED.

Revision history for this message
Zsombor Egri (zsombi) wrote :

Code looks good.

review: Approve
Revision history for this message
Tim Peeters (tpeeters) wrote :

Autopilot tests PASSED for gallery_app, webbrowser_app and notes_app for stable image 20130910.2 on device with the above UITK packages installed.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

trying again to see how random the autolanding results are :s

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

apparently there was a bug in unity that prevented app interaction, which causes the tests to fail. re-happroving to see if it is fixed now.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Affected by bug 1229110

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Made changes to ci test runners and pulled back the unity8 tests.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'modules/Ubuntu/Components/MainView.qml'
--- modules/Ubuntu/Components/MainView.qml 2013-08-22 17:15:35 +0000
+++ modules/Ubuntu/Components/MainView.qml 2013-09-23 08:52:24 +0000
@@ -247,7 +247,12 @@
247 clip: headerItem.bottomY > 0 && activePage && activePage.flickable247 clip: headerItem.bottomY > 0 && activePage && activePage.flickable
248 && -activePage.flickable.contentY < headerItem.bottomY248 && -activePage.flickable.contentY < headerItem.bottomY
249249
250 property Page activePage: mainView.activeLeafNode250 property Page activePage: isPage(mainView.activeLeafNode) ? mainView.activeLeafNode : null
251
252 function isPage(item) {
253 return item.hasOwnProperty("__isPageTreeNode") && item.__isPageTreeNode &&
254 item.hasOwnProperty("title") && item.hasOwnProperty("tools");
255 }
251256
252 Item {257 Item {
253 id: contents258 id: contents
254259
=== modified file 'modules/Ubuntu/Components/Page.qml'
--- modules/Ubuntu/Components/Page.qml 2013-08-22 17:08:11 +0000
+++ modules/Ubuntu/Components/Page.qml 2013-09-23 08:52:24 +0000
@@ -151,8 +151,14 @@
151 UnityActions.ActionContext {151 UnityActions.ActionContext {
152 id: actionContext152 id: actionContext
153153
154 Component.onCompleted: {154 property var actionManager: page.__propagated &&
155 var manager = page.__propagated.actionManager;155 page.__propagated.hasOwnProperty("actionManager") ?
156 page.__propagated.actionManager : null
157
158 onActionManagerChanged: addLocalContext(actionManager)
159 Component.onCompleted: addLocalContext(actionManager)
160
161 function addLocalContext(manager) {
156 if (manager) manager.addLocalContext(actionContext);162 if (manager) manager.addLocalContext(actionContext);
157 }163 }
158 }164 }

Subscribers

People subscribed via source and target branches

to status/vote changes: