Code review comment for lp:~tpeeters/ubuntu-ui-toolkit/fixPopoverPointer

Revision history for this message
Cris Dywan (kalikiana) wrote :

Works very well. As agreed on IRC it's unfortunate we have no tests so bug 1317226 accounts for that. Manual testing is possible by either checking the popover example in the gallery on a phone, or making the window very small on the desktop, and observing the position of the arrow - it should stay on the bottom, without the fix is moves to the top.

review: Approve

« Back to merge proposal