Merge lp:~tpeeters/ubuntu-ui-toolkit/deprecateSubHeader into lp:ubuntu-ui-toolkit/staging

Proposed by Tim Peeters
Status: Merged
Approved by: Cris Dywan
Approved revision: 2000
Merged at revision: 1998
Proposed branch: lp:~tpeeters/ubuntu-ui-toolkit/deprecateSubHeader
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 48 lines (+14/-0)
3 files modified
src/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+3/-0)
src/Ubuntu/Components/Styles/1.3/PageHeadStyle.qml (+1/-0)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml (+10/-0)
To merge this branch: bzr merge lp:~tpeeters/ubuntu-ui-toolkit/deprecateSubHeader
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Cris Dywan Approve
Review via email: mp+296919@code.launchpad.net

Commit message

Draw a red outline around the subheader in AdaptivePageLayout to warn that the old header is deprecated.

Description of the change

As announced on the ubuntu-phone mailing list. PageHeader should be used instead of the Page.head property.

You can use tst_multicolumnheader.qml to test it.

To post a comment you must log in.
1999. By Tim Peeters

revert change to export_qml_dir.sh

2000. By Tim Peeters

capitalization in comment

Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

I like it, not overly intrusive but clearly visible, and simple implementation.

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/Components/1.3/AdaptivePageLayout.qml'
--- src/Ubuntu/Components/1.3/AdaptivePageLayout.qml 2016-05-25 12:48:10 +0000
+++ src/Ubuntu/Components/1.3/AdaptivePageLayout.qml 2016-06-09 10:38:15 +0000
@@ -827,6 +827,9 @@
827 property color panelColor: layout.__propagated.header.panelColor827 property color panelColor: layout.__propagated.header.panelColor
828 property color backgroundColor: layout.__propagated.header.backgroundColor828 property color backgroundColor: layout.__propagated.header.backgroundColor
829829
830 // Enable red outline in the PageHeadStyle. See bug #1583636.
831 property bool showDeprecatedWarning: true
832
830 visible: !customHeader && holder.pageWrapper && holder.pageWrapper.active833 visible: !customHeader && holder.pageWrapper && holder.pageWrapper.active
831834
832 // The multiColumn, page and showBackButton properties are used in835 // The multiColumn, page and showBackButton properties are used in
833836
=== modified file 'src/Ubuntu/Components/Styles/1.3/PageHeadStyle.qml'
--- src/Ubuntu/Components/Styles/1.3/PageHeadStyle.qml 2015-09-22 14:39:47 +0000
+++ src/Ubuntu/Components/Styles/1.3/PageHeadStyle.qml 2016-06-09 10:38:15 +0000
@@ -17,6 +17,7 @@
1717
18/*!18/*!
19 \qmltype PageHeadStyle19 \qmltype PageHeadStyle
20 \deprecated
20 \inqmlmodule Ubuntu.Components.Styles 1.121 \inqmlmodule Ubuntu.Components.Styles 1.1
21 \ingroup style-api22 \ingroup style-api
22 \brief Style API for page header.23 \brief Style API for page header.
2324
=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml'
--- src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml 2016-02-29 16:02:50 +0000
+++ src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml 2016-06-09 10:38:15 +0000
@@ -50,8 +50,18 @@
50 */50 */
51 property color backgroundColor: styledItem.backgroundColor51 property color backgroundColor: styledItem.backgroundColor
52 Rectangle {52 Rectangle {
53 id: background
53 anchors.fill: parent54 anchors.fill: parent
54 color: headerStyle.backgroundColor55 color: headerStyle.backgroundColor
56
57 // The border is shown to warn the developer that the AppHeader
58 // is deprecated. See bug #1583636
59 property bool showBorder: styledItem.hasOwnProperty("showDeprecatedWarning") &&
60 styledItem.showDeprecatedWarning
61 border {
62 width: background.showBorder ? units.gu(0.5) : 0
63 color: background.showBorder ? UbuntuColors.red : "transparent"
64 }
55 }65 }
5666
57 // FIXME: When the three panel color properties below are removed,67 // FIXME: When the three panel color properties below are removed,

Subscribers

People subscribed via source and target branches