Ubuntu UI Toolkit

Code review comment for lp:~tpeeters/ubuntu-ui-toolkit/actionVisibility

  1. actionVisibility
  2. Merge into staging
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Wow this works beautifully! Without this MP, here is how it looks. https://imgur.com/5SdHwlw.

After using this MP, when you navigate to the timer tab, you are shown a + button to create a new timer as shown at
https://imgur.com/BdwUU8m. After pressing on it, it hides the + button and shows the save and cancel button as seen in https://imgur.com/IvHiFO0. I did not see any Actions.visibility property being deprecated or anything. The show/hiding of actions seems to work nicely.

Approving.

review: Approve (testing)

« Back to merge proposal