Merge lp:~tpeeters/music-app/fix-go-back into lp:music-app/trusty

Proposed by Tim Peeters
Status: Merged
Approved by: Leo Arias
Approved revision: 539
Merged at revision: 538
Proposed branch: lp:~tpeeters/music-app/fix-go-back
Merge into: lp:music-app/trusty
Diff against target: 47 lines (+3/-9)
2 files modified
tests/autopilot/music_app/emulators.py (+0/-3)
tests/autopilot/music_app/tests/test_music.py (+3/-6)
To merge this branch: bzr merge lp:~tpeeters/music-app/fix-go-back
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Leo Arias (community) looks good Approve
Review via email: mp+228120@code.launchpad.net

Commit message

Update autopilot tests to use the UITK CPO for clicking the back button.

Description of the change

Update autopilot tests to use the UITK CPO for clicking the back button.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) :
review: Approve (looks good)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/autopilot/music_app/emulators.py'
--- tests/autopilot/music_app/emulators.py 2014-07-24 07:23:11 +0000
+++ tests/autopilot/music_app/emulators.py 2014-07-24 14:01:54 +0000
@@ -113,9 +113,6 @@
113 def get_first_genre_item(self):113 def get_first_genre_item(self):
114 return self.wait_select_single("*", objectName="genreItemObject")114 return self.wait_select_single("*", objectName="genreItemObject")
115115
116 def get_back_button(self):
117 return self.select_single("AbstractButton", objectName="backButton")
118
119 def get_albumstab(self):116 def get_albumstab(self):
120 return self.select_single("Tab", objectName="albumstab")117 return self.select_single("Tab", objectName="albumstab")
121118
122119
=== modified file 'tests/autopilot/music_app/tests/test_music.py'
--- tests/autopilot/music_app/tests/test_music.py 2014-07-02 23:10:40 +0000
+++ tests/autopilot/music_app/tests/test_music.py 2014-07-24 14:01:54 +0000
@@ -125,8 +125,7 @@
125 self.assertThat(queueTrackTitle.text, Equals(self.trackTitle))125 self.assertThat(queueTrackTitle.text, Equals(self.trackTitle))
126126
127 # click on close button to close the page127 # click on close button to close the page
128 backButton = self.main_view.get_back_button()128 self.main_view.go_back()
129 self.pointing_device.click_object(backButton)
130129
131 if self.main_view.wideAspect:130 if self.main_view.wideAspect:
132 play_button = self.main_view.get_now_playing_play_button()131 play_button = self.main_view.get_now_playing_play_button()
@@ -346,8 +345,7 @@
346 self.assertThat(songs_page_albumartist.text, Equals(self.artistName))345 self.assertThat(songs_page_albumartist.text, Equals(self.artistName))
347346
348 # click on close button to close album page347 # click on close button to close album page
349 backButton = self.main_view.get_back_button()348 self.main_view.go_back()
350 self.pointing_device.click_object(backButton)
351 self.assertThat(self.main_view.get_albumstab(), Not(Is(None)))349 self.assertThat(self.main_view.get_albumstab(), Not(Is(None)))
352350
353 def test_add_song_to_queue_from_albums_page(self):351 def test_add_song_to_queue_from_albums_page(self):
@@ -377,8 +375,7 @@
377 self.assertThat(queueTrackTitle.text, Equals(self.trackTitle))375 self.assertThat(queueTrackTitle.text, Equals(self.trackTitle))
378376
379 # click on close button to close album page377 # click on close button to close album page
380 backButton = self.main_view.get_back_button()378 self.main_view.go_back()
381 self.pointing_device.click_object(backButton)
382 self.assertThat(self.main_view.get_albumstab(), Not(Is(None)))379 self.assertThat(self.main_view.get_albumstab(), Not(Is(None)))
383380
384 def test_add_songs_to_queue_from_songs_tab_and_play(self):381 def test_add_songs_to_queue_from_songs_tab_and_play(self):

Subscribers

People subscribed via source and target branches

to status/vote changes: