Code review comment for lp:~tpatil/nova/os-security-groups

Revision history for this message
Tushar Patil (tpatil) wrote :

> The changes look good; thanks for pointing me to the filtering in
> sqlalchemy/api.py - that's what I was looking for.
>
> One minor problem: lines 210 and 337 still have the localization function call
> around 'msg'; it's not needed, and should be removed. Only literal strings
> ever need to be localized.
I should have noticed this before. Anyway I have fixed it now.

« Back to merge proposal