As noted by bcwaldon & blamar in https://code.launchpad.net/~cloudbuilders/nova/os-floating-ips-redux/+merge/71922 we should switch the add/remove to being server actions like:
166 + 167 + def get_actions(self): 168 + """Return the actions the extension adds, as required by contract.""" 169 + actions = [ 170 + extensions.ActionExtension("servers", "addFloatingIp", 171 + self._add_floating_ip), 172 + extensions.ActionExtension("servers", "removeFloatingIp", 173 + self._remove_floating_ip), 174 + ] 175 + 176 + return actions
Other than that LGTM
« Back to merge proposal
As noted by bcwaldon & blamar in https:/ /code.launchpad .net/~cloudbuil ders/nova/ os-floating- ips-redux/ +merge/ 71922 we should switch the add/remove to being server actions like:
166 + ActionExtension ("servers" , "addFloatingIp", floating_ ip), ActionExtension ("servers" , "removeFloatingIp", floating_ ip),
167 + def get_actions(self):
168 + """Return the actions the extension adds, as required by contract."""
169 + actions = [
170 + extensions.
171 + self._add_
172 + extensions.
173 + self._remove_
174 + ]
175 +
176 + return actions
Other than that LGTM