Code review comment for lp:~tpatil/nova/add-options-network-create-os-apis

Hi Tushar,

Thanks for this work, it will indeed be very helpful. In fact, we need something quite similar for our QuantumManager work in nova. I've implemented this in another branch, but I don't see a point in trying to merge two sets of code that do basically the same thing. I think with one small tweak this code could work for us as well.

The change would be to no longer assume that the network-id must be an integer, but instead allow it to be a UUID (which is what quantum uses to identify networks).

This would apply in create_instance_helper.py, where the code calls:

network_id = int(network_id)

and then catches any resulting exceptions. It seems like that validation could actually be performed as part of the call to validate networks:

self.network_api.validate_networks(context, requested_networks)

This way, a NetworkManager way the typing could be specific to the network manager.

Thoughts?