Code review comment for lp:~tpatil/nova/add-options-network-create-os-apis

Revision history for this message
Tushar Patil (tpatil) wrote :

> Great. Don't worry about only exposing this in V1.1. It isn't changing the
> interface, it is just adding to it. We will cover this in the future once we
> have schema validation.

I need one more clarification to avoid rework. If I add everything in the create_instance_helper.py, my changes will be accessible by both OS V1.0 and V1.1 since CreateInstanceHelper class is used by both of the controllers. After schema validation will be implemented each controller will do the schema validation based on its own schema and take an action.

But till the time schema validation is not implemented, it is possible to create server with the required network information using below URIs. Is this acceptable?
http://10.2.3.150:8774/v1.1/os-create-server-ext
http://10.2.3.150:8774/v1.0/servers
http://10.2.3.150:8774/v1.1/servers

XML request
-------------
<?xml version="1.0" encoding="UTF-8"?>
<server name="new-server-test" flavorRef="1"
        imageRef="46">
  <metadata>
    <meta key="My Server Name">Apache1</meta>
  </metadata>
<personality/>
<networks>
    <network id="1" fixed_ip="10.0.1.15" />
</networks>
</server>

« Back to merge proposal