Code review comment for lp:~tpatil/nova/add-options-network-create-os-apis

Revision history for this message
Brian Waldon (bcwaldon) wrote :

> > I think it makes more sense for you to put whatever changes you need to make
> > in the main create_instance_helper.py module. The duplication in
> > nova/api/openstack/contrib/createserverext.py is going to be difficult to
> keep
> > up with. Like I said earlier, your code can live in the main codebase, you
> > just need to have an ExtensionDescriptor in contrib/ (which you do).
> Now, I have understood your comments correctly. I will revert my changes
> accordingly. I will also have to write my unit test cases in the
> test_server.py instead of test/api/openstack/contrip/test_createserverext.py.
>
> In one of your previous comments, you mention I have to limit these new
> changes only in the V1.1 without disturbing V1.0. To do this, I will need to
> add a new method _network_ref_from_req_data to both ControllerV11 and
> ControllerV10. ControllerV10 will simply return None whereas ControllerV11
> will return the actual network reference data.

Great. Don't worry about only exposing this in V1.1. It isn't changing the interface, it is just adding to it. We will cover this in the future once we have schema validation.

« Back to merge proposal