Code review comment for lp:~tpatil/nova/add-options-network-create-os-apis

Revision history for this message
Brian Waldon (bcwaldon) wrote :

> Thank you for your time to review my code.
>
> > 1) The v1.0 api cannot be changed. You will need to limit your changes to
> the
> > v1.1 api.
> Ok, understood.
> > 2) This is not in the v1.1 spec, so it will have to be documented as an
> > extension. I think it is okay for the v1.1 code to remain unchanged, but you
> > will need to add an extension descriptor to document the change.
> You mean I should add this as an extension under api/openstack/contrib
> directory of nova. Please confirm.

You should add a module in api.openstack.contrib, but the only code you need in it is an implementation of nova.api.openstack.extensions.ExtensionDescriptor. See api.openstack.contrib.volumes for an example of the descriptor. Basically, you need to describe the difference in our (Nova's) implementation of the v1.1 spec.

« Back to merge proposal