Code review comment for lp:~tpatil/nova/add-options-network-create-os-apis

Revision history for this message
Tushar Patil (tpatil) wrote :

Thank you for your time to review my code.

> 1) The v1.0 api cannot be changed. You will need to limit your changes to the
> v1.1 api.
Ok, understood.
> 2) This is not in the v1.1 spec, so it will have to be documented as an
> extension. I think it is okay for the v1.1 code to remain unchanged, but you
> will need to add an extension descriptor to document the change.
You mean I should add this as an extension under api/openstack/contrib directory of nova. Please confirm.

« Back to merge proposal