Unity

Code review comment for lp:~townsend/unity/fix-urgent-icon-wiggle

  1. fix-urgent-icon-wiggle
  2. Merge into trunk
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Nice...

229 + EXPECT_FALSE(launcher_->_urgent_timer_running);

244 + EXPECT_EQ(launcher_->_urgent_wiggle_time, 0);
245 + EXPECT_EQ(launcher_->_urgent_finished_time.tv_sec, 0);
246 + EXPECT_EQ(launcher_->_urgent_finished_time.tv_nsec, 0);

Probably better to use ASSERT_EQ there^.

Is it now possible to also test that the icons wiggle once the launcher is shown?

« Back to merge proposal