Merge lp:~townsend/unity/fix-quicklist-spread into lp:unity

Proposed by Christopher Townsend
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 3966
Proposed branch: lp:~townsend/unity/fix-quicklist-spread
Merge into: lp:unity
Diff against target: 30 lines (+9/-4)
1 file modified
launcher/LauncherIcon.cpp (+9/-4)
To merge this branch: bzr merge lp:~townsend/unity/fix-quicklist-spread
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+257300@code.launchpad.net

Commit message

Wait on Spread to be terminated before showing the Quicklist.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Right...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'launcher/LauncherIcon.cpp'
--- launcher/LauncherIcon.cpp 2015-03-20 16:23:04 +0000
+++ launcher/LauncherIcon.cpp 2015-04-23 20:19:52 +0000
@@ -577,10 +577,6 @@
577 }577 }
578578
579 WindowManager& win_manager = WindowManager::Default();579 WindowManager& win_manager = WindowManager::Default();
580
581 if (win_manager.IsScaleActive())
582 win_manager.TerminateScale();
583
584 auto const& pos = GetTipPosition(monitor);580 auto const& pos = GetTipPosition(monitor);
585581
586 /* If the expo plugin is active, we need to wait it to be terminated, before582 /* If the expo plugin is active, we need to wait it to be terminated, before
@@ -593,6 +589,15 @@
593 conn->disconnect();589 conn->disconnect();
594 });590 });
595 }591 }
592 else if (win_manager.IsScaleActive())
593 {
594 auto conn = std::make_shared<sigc::connection>();
595 *conn = win_manager.terminate_spread.connect([this, conn, pos, restore_input_focus] {
596 QuicklistManager::Default()->ShowQuicklist(_quicklist, pos.x, pos.y, restore_input_focus);
597 conn->disconnect();
598 });
599 win_manager.TerminateScale();
600 }
596 else601 else
597 {602 {
598 QuicklistManager::Default()->ShowQuicklist(_quicklist, pos.x, pos.y, restore_input_focus);603 QuicklistManager::Default()->ShowQuicklist(_quicklist, pos.x, pos.y, restore_input_focus);