Code review comment for lp:~townsend/unity/fix-extra-decorations

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

It seems that the same code is also in trunk, do we have the same bug in saucy?
If yes we should probably propose for it before.

However, why not keeping IsWindowDecorated inside Undecorate and modifying it so that it returns immediately false if HasWindowDecorations returns false (if doing this we should probably think also to a way to optimize the calls, so that we reduce to the minimum the GetMwnDecorations [i.e. XGetWindowProperty] calls)?

« Back to merge proposal