Code review comment for lp:~townsend/lightdm/fix-plymouthd-spin

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I thought the absence of plymouth_quit wass correct. Lightdm is not meant to quit plymouth, only deactivate it...

I thought you should not want plymouth quit because we needed a faster and smoother transition on startup, which deactivate gives you(?). But I also can't see any reason why plymouthd should keep running, so quit might make sense.

review: Needs Information

« Back to merge proposal