Merge lp:~townsend/compiz/fix-lp1251777 into lp:compiz/0.9.11

Proposed by Christopher Townsend
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 3807
Merged at revision: 3812
Proposed branch: lp:~townsend/compiz/fix-lp1251777
Merge into: lp:compiz/0.9.11
Diff against target: 78 lines (+21/-7)
3 files modified
debian/patches/ubuntu-config.patch (+6/-5)
plugins/grid/grid.xml.in (+10/-0)
plugins/grid/src/grid.cpp (+5/-2)
To merge this branch: bzr merge lp:~townsend/compiz/fix-lp1251777
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+197793@code.launchpad.net

Commit message

* Add new Grid shortcuts for Ctrl-Super-Left/Right to left/right semi-maximize windows (removed from Unity).
* Patch Grid to use Ctrl-Super-Up to maximize a gridded window instead of using core. This helps in restoring a window back to it's original place before being gridded.
* Account for left and right borders when restoring a gridded window since the window would shrink and shift by this amount.

Description of the change

* Add new Grid shortcuts for Ctrl-Super-Left/Right to left/right semi-maximize windows (removed from Unity in another MP).
* Patch Grid to use Ctrl-Super-Up to maximize a gridded window instead of using core. This helps in restoring a window back to it's original place before being gridded.
* Account for left and right borders when restoring a gridded window since the window would shrink and shift by this amount.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/patches/ubuntu-config.patch'
--- debian/patches/ubuntu-config.patch 2013-11-11 20:07:16 +0000
+++ debian/patches/ubuntu-config.patch 2013-12-04 20:00:45 +0000
@@ -699,13 +699,14 @@
699 bool Advance (Display *d, bool r)699 bool Advance (Display *d, bool r)
700Index: compiz/plugins/grid/grid.xml.in700Index: compiz/plugins/grid/grid.xml.in
701===================================================================701===================================================================
702--- compiz.orig/plugins/grid/grid.xml.in 2013-10-08 17:00:56.932757923 +0200702--- compiz.orig/plugins/grid/grid.xml.in 2013-12-04 12:23:44.021963832 -0500
703+++ compiz/plugins/grid/grid.xml.in 2013-10-08 17:01:05.104735978 +0200703+++ compiz/plugins/grid/grid.xml.in 2013-12-04 12:24:43.885963254 -0500
704@@ -68,12 +68,11 @@704@@ -68,12 +68,12 @@
705 <option name="put_maximize_key" type="key">705 <option name="put_maximize_key" type="key">
706 <_short>Maximize Key</_short>706 <_short>Maximize Key</_short>
707 <_long>Maximize window.</_long>707 <_long>Maximize window.</_long>
708- <default>&lt;Control&gt;&lt;Alt&gt;KP_0</default>708- <default>&lt;Control&gt;&lt;Alt&gt;KP_0</default>
709+ <default>&lt;Control&gt;&lt;Super&gt;Up</default>
709 </option>710 </option>
710 <option name="put_restore_key" type="key">711 <option name="put_restore_key" type="key">
711 <_short>Restore</_short>712 <_short>Restore</_short>
@@ -713,8 +714,8 @@
713- <default>&lt;Alt&gt;F5</default>714- <default>&lt;Alt&gt;F5</default>
714+ <default>&lt;Control&gt;&lt;Super&gt;Down</default>715+ <default>&lt;Control&gt;&lt;Super&gt;Down</default>
715 </option>716 </option>
716 </group>717 <option name="left_maximize" type="key">
717 <group>718 <_short>Left Maximize</_short>
718Index: compiz/plugins/ezoom/ezoom.xml.in719Index: compiz/plugins/ezoom/ezoom.xml.in
719===================================================================720===================================================================
720--- compiz.orig/plugins/ezoom/ezoom.xml.in 2013-10-08 17:00:56.932757923 +0200721--- compiz.orig/plugins/ezoom/ezoom.xml.in 2013-10-08 17:00:56.932757923 +0200
721722
=== modified file 'plugins/grid/grid.xml.in'
--- plugins/grid/grid.xml.in 2013-05-11 08:04:34 +0000
+++ plugins/grid/grid.xml.in 2013-12-04 20:00:45 +0000
@@ -75,6 +75,16 @@
75 <_long>Restore window to it's original size. Note: Use the same shortcut you are using to unmaximize a window to be able to restore grid-maximized windows.</_long>75 <_long>Restore window to it's original size. Note: Use the same shortcut you are using to unmaximize a window to be able to restore grid-maximized windows.</_long>
76 <default>&lt;Alt&gt;F5</default>76 <default>&lt;Alt&gt;F5</default>
77 </option>77 </option>
78 <option name="left_maximize" type="key">
79 <_short>Left Maximize</_short>
80 <_long>Left vertically maximize window.</_long>
81 <default>&lt;Control&gt;&lt;Super&gt;Left</default>
82 </option>
83 <option name="right_maximize" type="key">
84 <_short>Right Maximize</_short>
85 <_long>Right vertically maximize window.</_long>
86 <default>&lt;Control&gt;&lt;Super&gt;Right</default>
87 </option>
78 </group>88 </group>
79 <group>89 <group>
80 <_short>Corners / Edges</_short>90 <_short>Corners / Edges</_short>
8191
=== modified file 'plugins/grid/src/grid.cpp'
--- plugins/grid/src/grid.cpp 2013-11-15 22:58:47 +0000
+++ plugins/grid/src/grid.cpp 2013-12-04 20:00:45 +0000
@@ -1020,8 +1020,8 @@
1020 else if (isGridVertMaximized)1020 else if (isGridVertMaximized)
1021 {1021 {
1022 window->saveMask () |= CWX | CWWidth;1022 window->saveMask () |= CWX | CWWidth;
1023 window->saveWc ().x = originalSize.x ();1023 window->saveWc ().x = originalSize.x () - window->border ().left;
1024 window->saveWc ().width = originalSize.width ();1024 window->saveWc ().width = originalSize.width () + window->border ().left + window->border ().right;
1025 }1025 }
10261026
1027 if ((isGridHorzMaximized &&1027 if ((isGridHorzMaximized &&
@@ -1314,6 +1314,9 @@
1314 GRIDSET (PutBottomrightKey, GridWindowType::GridBottomRight, true, true);1314 GRIDSET (PutBottomrightKey, GridWindowType::GridBottomRight, true, true);
1315 GRIDSET (PutMaximizeKey, GridWindowType::GridMaximize, true, true);1315 GRIDSET (PutMaximizeKey, GridWindowType::GridMaximize, true, true);
13161316
1317 GRIDSET (RightMaximize, GridWindowType::GridRight, true, true);
1318 GRIDSET (LeftMaximize, GridWindowType::GridLeft, true, true);
1319
1317#undef GRIDSET1320#undef GRIDSET
13181321
1319 optionSetPutRestoreKeyInitiate (boost::bind (&GridScreen::1322 optionSetPutRestoreKeyInitiate (boost::bind (&GridScreen::

Subscribers

People subscribed via source and target branches