Code review comment for lp:~torkvemada/bzr/commit_hooks

Revision history for this message
Vsevolod Velichko (torkvemada) wrote :

Martin, the idea of class with custom fields is cool (before your comment I was unsure about it, since I hadn't seen other hooks with such idea in bzr).
I've updated the hook, so it passes only limited set of params (I've eliminated even the message, I suppose that set_commit_message hook should be enough) and added some tests for invalid data.

« Back to merge proposal