Code review comment for lp:~torkvemada/bzr/commit_hooks

Revision history for this message
Vsevolod Velichko (torkvemada) wrote :

Jelmer, thanks for your look.
I thought about the idea passing the properties dict itself to the hook, but finally I supposed that one may wish to access commit timestamp or something like that.
Obviously, if you are sure, that one should never wish things like that, I can modify the hook and pass the properties dict :)
Or may be there should be some special struct having only "safe" fields?

« Back to merge proposal